dgb: wire -DAUX_DOGE build-flag seam (phase DA) - #310
Merged
Conversation
Un-stub the parked AUX_DOGE option in the dgb module CMakeLists so the DGB-as-DOGE-parent dual-parent merged-mining stretch can be opted into at configure time. When -DAUX_DOGE=ON the AUX_DOGE compile macro is defined across the dgb subtree, compiling the inert aux seam already present in coin/node.hpp (forward-decl of doge::coin::AuxChainEmbedded, the AuxChainBackend type alias, and the bind_aux_doge_parsers() declaration -- no body, never ODR-used). Default OFF leaves the standalone Scrypt-only parent build byte-unchanged with zero DOGE coupling. The shared src/impl/doge aux module (ltc-doge owns) is still only CONSUMED at M3/DB, when the real aux_chain_embedded.hpp include and the bind body land; this slice adds no shared-module dependency. Prereq #82 (own-block broadcaster) is closed. Verified: configure -DCOIN_DGB=ON -DAUX_DOGE=ON EXIT=0 (option message fires); dgb_aux_parent_coinbase_parity_test builds EXIT=0 under the macro and runs 4/4 green.
frstrtr
added a commit
that referenced
this pull request
Jun 22, 2026
…#312) #310 landed the -DAUX_DOGE opt-in seam (option + add_compile_definitions in src/impl/dgb/CMakeLists.txt; #ifdef AUX_DOGE in coin/node.hpp) but nothing in CI exercises the flag-ON path, so the dual-parent stretch seam could rot dark between now and M3. Add a dedicated coin-dgb-auxdoge job that configures with -DCOIN_DGB=ON -DAUX_DOGE=ON and builds the c2pool-dgb binary, so the #ifdef AUX_DOGE seam is compiled on every PR. Default build (flag OFF) is unchanged and still covered by the linux + dgb-smoke jobs. Workflow file only; no source or shared-base touch. Stacked on dgb/ci-fix-build-yml-conflict-markers (#311) because that is the only clean build.yml base while master CI is red; rebase to master once #311 lands. Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
Un-stub the parked AUX_DOGE option in the dgb module CMakeLists so the DGB-as-DOGE-parent dual-parent merged-mining stretch can be opted into at configure time. When -DAUX_DOGE=ON the AUX_DOGE compile macro is defined across the dgb subtree, compiling the inert aux seam already present in coin/node.hpp (forward-decl of doge::coin::AuxChainEmbedded, the AuxChainBackend type alias, and the bind_aux_doge_parsers() declaration -- no body, never ODR-used). Default OFF leaves the standalone Scrypt-only parent build byte-unchanged with zero DOGE coupling. The shared src/impl/doge aux module (ltc-doge owns) is still only CONSUMED at M3/DB, when the real aux_chain_embedded.hpp include and the bind body land; this slice adds no shared-module dependency. Prereq #82 (own-block broadcaster) is closed. Verified: configure -DCOIN_DGB=ON -DAUX_DOGE=ON EXIT=0 (option message fires); dgb_aux_parent_coinbase_parity_test builds EXIT=0 under the macro and runs 4/4 green. Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
…#312) #310 landed the -DAUX_DOGE opt-in seam (option + add_compile_definitions in src/impl/dgb/CMakeLists.txt; #ifdef AUX_DOGE in coin/node.hpp) but nothing in CI exercises the flag-ON path, so the dual-parent stretch seam could rot dark between now and M3. Add a dedicated coin-dgb-auxdoge job that configures with -DCOIN_DGB=ON -DAUX_DOGE=ON and builds the c2pool-dgb binary, so the #ifdef AUX_DOGE seam is compiled on every PR. Default build (flag OFF) is unchanged and still covered by the linux + dgb-smoke jobs. Workflow file only; no source or shared-base touch. Stacked on dgb/ci-fix-build-yml-conflict-markers (#311) because that is the only clean build.yml base while master CI is red; rebase to master once #311 lands. Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DGB+DOGE merged-mining phase DA — build-flag seam
Un-stubs the parked
AUX_DOGEoption insrc/impl/dgb/CMakeLists.txtso the DGB-as-DOGE-parent dual-parent stretch can be opted in at configure time. With-DAUX_DOGE=ONtheAUX_DOGEcompile macro is defined across the dgb subtree, compiling the inert aux seam already present incoin/node.hpp(forward-decl ofdoge::coin::AuxChainEmbedded, theAuxChainBackendtype alias, and thebind_aux_doge_parsers()declaration — no body, never ODR-used).Fence (dgb-only)
src/impl/dgb/CMakeLists.txt. No shared-base / ltc / doge touch.add_compile_definitionsis insideif(AUX_DOGE)).src/impl/dogeaux module (ltc-doge owns) is CONSUMED only at M3/DB, when the realaux_chain_embedded.hppinclude + bind body land. This slice only lights up the inert seam.Verification
cmake -DCOIN_DGB=ON -DAUX_DOGE=ONconfigure EXIT=0 (ENABLED message fires)dgb_aux_parent_coinbase_parity_testbuilds EXIT=0 under the macro, runs 4/4 greenNotes
-DAUX_DOGE=ONconfigure arm to the dgb CI matrix so the path cannot silently rot.Bucket: per-coin (DGB) isolation primitive untouched; build-flag plumbing only.